>From <[email protected]>: Attention is currently required from: Ritik Raj. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636 )
Change subject: [ASTERIXDB-3596][STO] Fix double comparison in range filters ...................................................................... Patch Set 3: (1 comment) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/filters/DoubleColumnFilterWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636/comment/a85c868c_a995c46a PS3, Line 51: public static double denormalizeDouble(long x) { : if (x >= 0) : return Double.longBitsToDouble(x); : else : return Double.longBitsToDouble((-(x + 1)) | 0x8000000000000000L); : } > seems like not being used? if not, we can remove it. Yeah, its not used but I used it for debuggging the ColumnFilterComparator. So I thought I might as well keep it. Shall I remove? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I702c4e1ef6c46e532cf64a874ec6a81bea3ebaad Gerrit-Change-Number: 19636 Gerrit-PatchSet: 3 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 10 Apr 2025 16:45:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ritik Raj <[email protected]> Gerrit-MessageType: comment
