>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Murtadha Hubail, Janhavi Tripurwar, Ali 
Alsuliman.
Peeyush Gupta has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828 )

Change subject: [ASTERIXDB-3615][FUN]: lpad and rpad func
......................................................................


Patch Set 7:

(1 comment)

File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPadEvaluator.java:

PS6:
> I think we should do what MySQL and PostgresSQL do (i.e. truncate if length 
> is less). […]
truncate is happening if the padding provided is not empty string, for example 
following returns select lpad("abcd", 2, "a") returns ab with this patch which 
matches mysql and postgres



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ia74279fbbe9d23538c057cbbae9538cb219da1f2
Gerrit-Change-Number: 19828
Gerrit-PatchSet: 7
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-CC: Ali Alsuliman <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Janhavi Tripurwar <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Fri, 30 May 2025 18:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peeyush Gupta <[email protected]>
Comment-In-Reply-To: Ali Alsuliman <[email protected]>
Gerrit-MessageType: comment

Reply via email to