>From Janhavi Tripurwar <[email protected]>:
Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali
Alsuliman.
Janhavi Tripurwar has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828 )
Change subject: [ASTERIXDB-3615][FUN]: lpad and rpad func
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPadEvaluator.java:
PS6:
> One case which is not important but differs in output from MySQL, PostgreSQL,
> Oracle etc. […]
made the change,now lpad("abcd", 2, "") returns "ab" instead of "abcd". I
forgot to remove the padStrUtf8Len variable(no longer needed). I'll clean that
up along with any other comments.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ia74279fbbe9d23538c057cbbae9538cb219da1f2
Gerrit-Change-Number: 19828
Gerrit-PatchSet: 7
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-CC: Ali Alsuliman <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Fri, 30 May 2025 18:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Peeyush Gupta <[email protected]>
Gerrit-MessageType: comment
