>From Wail Alkowaileet <wael....@gmail.com>: Attention is currently required from: Ritik Raj. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 )
Change subject: [ASTERIXDB-3601][STO] Supporting multi-page zeroes ...................................................................... Patch Set 5: (1 comment) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/stream/in/MultiPageZeroByteBufferInputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/d548ba98_71c88504 PS5, Line 39: MultiPageZeroByteBufferInputStream I don't believe this class should exist. Why PageZero logic has to be in this "low-level" (i.e., Input/Output streams)? InputStreams were designed to work with decoders for data columns, where you need to read the data sequentially. You don't need to bring this logic here to streams (in fact this isn't a stream). I was imagining something that can interpret the bits in a buffer (something similar to ColumnBTreeReadLeafFrame). -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I8e54f0e6a8cb9f17a38394833f1c8990ce29676e Gerrit-Change-Number: 19944 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-CC: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Ritik Raj <ritik....@couchbase.com> Gerrit-Comment-Date: Wed, 18 Jun 2025 15:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
