>From Ritik Raj <ritik....@couchbase.com>: Attention is currently required from: Wail Alkowaileet. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 )
Change subject: [ASTERIXDB-3601][STO] Supporting multi-page zeroes ...................................................................... Patch Set 5: (1 comment) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/stream/in/MultiPageZeroByteBufferInputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/2008e8ef_986d34f0 PS5, Line 39: MultiPageZeroByteBufferInputStream > I don't believe this class should exist. Why PageZero logic has to be in this > "low-level" (i.e. […] The way I imagined the flow was like this, the request comes to the ColumnBTreeReadLeafFrame, which contains the zeroth PageZero and contains info about other pageZeros and other details. Now, ColumnBTreeReadLeafFrame calls pageZeroReader, which based on the column, decides it can read zeroth segment, or it should read the other segment. If the call is for other segment, it goes into this class and read specific bytes from the required buffer. yes, I should have done kinda same thing in a different class or in pageZeroReader itself, instead of putting it in `MultiPageZeroByteBufferInputStream` class. The behavior being expected from this class is not of stream, rather just read the bytes from byte[]. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I8e54f0e6a8cb9f17a38394833f1c8990ce29676e Gerrit-Change-Number: 19944 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-CC: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Wail Alkowaileet <wael....@gmail.com> Gerrit-Comment-Date: Wed, 18 Jun 2025 15:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <wael....@gmail.com> Gerrit-MessageType: comment
