>From Ali Alsuliman <ali.al.solai...@gmail.com>: Attention is currently required from: Shahrzad Shirazi, Michael Blow, Hussain Towaileb. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 )
Change subject: [NO ISSUE][COMP] Add None as quote option for CSV in external collections ...................................................................... Patch Set 18: (9 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/QuotedLineRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/b54c4231_6ffd962f PS12, Line 93: public boolean hasNext() throws IOException { > Yes, I just checked it, that would be a better option. […] What I meant is something like this: public boolean hasNext() throws IOException { if (!quoteCheckNeeded) { return super.hasNext(); } ... } File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/89819cdd_17a22aed PS18, Line 238: true Why not use the qouteCheckNeeded passed in the constructor? Same thing for below. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/2fc6fbd3_bf0cc85b PS18, Line 169: checkIfQouteIsNeeded Rename this to "isQuoteNeeded()" File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/DelimitedDataTupleParserFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/b16f3e84_1f872f08 PS18, Line 112: } Revert those line changes, here and above. File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/f69d2b94_4f650f85 PS12, Line 215: if (ch == '\n' && !startedQuote) { > I see, will work on it and add more test cases to make sure it is fine. Just checking. Did it actually fail like I was suggesting? because now that I read again, it should not fail, i.e. your original change should be ok. The new change looks like problematic actually since it does not detect that it has reached end of record. File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/d7e600a5_ed7a49da PS18, Line 78: //the delimiter Keep this comment next to the fieldDelimiter as it used to be https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/c7cb1934_e45c7221 PS18, Line 190: not needed extra line? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/ea2da5f0_2c3a883b PS18, Line 315: Remove those not needed extra lines. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/deeeb967_35f373c3 PS18, Line 486: } Do you have some kind of auto formatting that tries to remove trailing new lines? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3812d2d1306282e9f02e8b77e1f79ac6b203cabe Gerrit-Change-Number: 20146 Gerrit-PatchSet: 18 Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Tue, 12 Aug 2025 19:33:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shahrzad Shirazi <shaji...@ucr.edu> Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
