>From Ali Alsuliman <ali.al.solai...@gmail.com>: Attention is currently required from: Shahrzad Shirazi, Michael Blow, Hussain Towaileb. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 )
Change subject: [NO ISSUE][COMP] Add None as quote option for CSV in external collections ...................................................................... Patch Set 20: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/QuotedLineRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/4902fcf7_d0705153 PS20, Line 119: quoteCheckNeeded Do we need this? File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/d60c31c1_82a8e2ac PS20, Line 209: else if (ch == fieldDelimiter) Just curios why this else-if for fieldDelimiter was moved inside -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3812d2d1306282e9f02e8b77e1f79ac6b203cabe Gerrit-Change-Number: 20146 Gerrit-PatchSet: 20 Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Thu, 14 Aug 2025 16:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
