>From Shahrzad Shirazi <shaji...@ucr.edu>: Shahrzad Shirazi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729 )
Change subject: [ASTERIXDB-3637][COMP] Simplify Index-only plan ...................................................................... Patch Set 47: (7 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/077f5e77_463d0f77 PS43, Line 7: NO ISSUE > Create an *DB issue and use it here. Also rebase the patch. Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/b917a2db_a1d4a2e3 PS20, Line 1341: origVarToOutputVarMap.put(pkVarsFromSIdxUnnestMapOp.get(0), newMissingPlaceHolderForLOJ); > Can you check why this is needed? Every Var needed in this is handled by origVarToOutputVarMap in the new code and it will keep the mapping between the old version of the pk and sks to the new ones. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/7a2a2d05_d9be6502 PS43, Line 99: IAType filterSourceType = filterSourceIndicator == null || filterSourceIndicator == 0 > We don't need to change this, right? Same thing at the very end of the file. Yes we do not, I keep making this to what it was but for some reason it changes to this again!! File asterixdb/asterix-app/src/test/resources/optimizerts/results/ASTERIXDB-2402.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/3a8d2c2f_4d769d8d PS43, Line 8: [cardinality: 0.0, doc-size: 0.0, op-cost: 0.0, total-cost: 0.0] > Can you remove these from all optimizerts plans? Sorry, the other time I only removed this for one class. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/runningaggregates/std/WinMarkHalloweenRunningAggregateDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/5b7b36c5_fe71ae1d PS20, Line 33: WinMarkHalloweenRunningAggregateDescriptor > Sorry forgot about the second section will add it in the last version. Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/runningaggregates/std/WinMarkValidTuplesRunningAggregateEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/117b294f_eb2c92ad PS43, Line 80: if (first) { > Do it like this: […] Not sure if I wrote it or not,is what we have now right? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/0cf21440_c50231b2 PS43, Line 107: return false; > I keep forgetting. […] We keep the tuple when it is the same, if it is different it means that we have more than one value for the secondary key so we will throw the different ones away. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I516dc90b8da3a7086dc80b67946a5d4f6dde0972 Gerrit-Change-Number: 17729 Gerrit-PatchSet: 47 Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Comment-Date: Tue, 26 Aug 2025 06:35:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shahrzad Shirazi <shaji...@ucr.edu> Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
