>From Ali Alsuliman <ali.al.solai...@gmail.com>:

Attention is currently required from: Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729 )

Change subject: [ASTERIXDB-3637][COMP] Simplify Index-only plan
......................................................................


Patch Set 47:

(4 comments)

File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/btree-index-composite-key-04.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/20b45edd_c1072526
PS47, Line 16: -- HASH_PARTITION_EXCHANGE [$$22]  |PARTITIONED|
I wasn't expecting a hash-join. The plan seems a bit odd. Can you please check 
what happened?


File 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/heterogeneous-index-only-compund-keys/heterogeneous-index-only-compund-keys.5.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/b070accf_6933b011
PS47, Line 11: data-scan []<-[$$18, $$c] <- test.Customers
Can you file an issue for CBO? Index-only should be cheaper than data-scan.


File 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/leftouterjoin/index-only-leftouterjoin/index-only-leftouterjoin.008.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/58fb4729_01a9be63
PS47, Line 35: retain-untrue ($$54 <- missing)
I am not sure if this is going to work now that there is above it:
-- HASH_PARTITION_EXCHANGE [$$54]

This will cause the same record from "idx_c_int32" to be potentially in two 
different partitions for the case when $$54 is valued and missing, e.g.:
- RC1 from ds_outer_untyped joins with $$54 and $$54 is produced with its value.
- $$54 value changes.
- RC2 from ds_outer_untyped does not join with $$54 and $$54 is produced as 
missing.

We basically want all $$54s to be in the same partition to eliminate 
duplicates, right?


File 
asterixdb/asterix-app/src/test/resources/runtimets/results_column/index-only-testcases/simple-index-only/simple-index-only.4.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/452d660c_d6033fd5
PS47, Line 15: data-scan []<-[$$21, $$Orders] <- test.Orders project
Just checking, is this supposed to be a data-scan or index-only?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I516dc90b8da3a7086dc80b67946a5d4f6dde0972
Gerrit-Change-Number: 17729
Gerrit-PatchSet: 47
Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: Shahrzad Shirazi <shaji...@ucr.edu>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to