>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ian Maxon, Murtadha Hubail.
Peeyush Gupta has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email ) Change subject: [ASTERIXDB-3649][*DB] Improve async request API ...................................................................... Patch Set 11: (15 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/PushdownContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/48babd07_9035e28e?usp=email : PS9, Line 153: > nit: revert? Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/29417c37_3a9b669f?usp=email : PS9, Line 108: private static final long serialVersionUID = 2L; > 1L Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/5545555d_5f5b547f?usp=email : PS9, Line 115: protected void handleExecuteStatementException(Throwable t, > remove one Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/bd80ea83_43205df2?usp=email : PS9, Line 156: if (error instanceof ErrorCode) { > why not keep it an IError and predicate this on the value of IError. […] Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryResultApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/d0649a2c_3406636f?usp=email : PS9, Line 60: messageFuture.get(DEFAULT_NC_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); > This can wait forever if CC sides after receiving the message. […] Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/6d4bce0b_5313931d?usp=email : PS9, Line 160: private boolean includeHostInHandle = true; > Let's default this to false, and automatically set it to true on deferred for > back compt with the JD […] Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DiscardResultPartitionRequestMessage.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/9d49a0a2_ae8b3fd1?usp=email : PS9, Line 49: LOGGER.info("failed to get collection size", e); > fix Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/067aba48_2682c59a?usp=email : PS9, Line 86: private void printSelected(PrintWriter pw) { > remove duplicated printing code Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/7e5d3186_cd01cc6c?usp=email : PS9, Line 562: metadataProvider.setMaxResultReads(!sessionConfig.isIncludeHostInHandle() ? 0 : maxResultReads); > refactor this as a constant called unlimited reads Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/f86cb4b1_da3570e9?usp=email : PS9, Line 4546: org.apache.asterix.translator.ResultMetadata resultMetadata) throws AlgebricksException, ACIDException { > whys this a fully-qualified import? There is another class with the same name imported already. File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/AsyncRequestsAPIUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/ce6b456c_ea01815f?usp=email : PS9, Line 122: throw new RuntimeException(e); > replace these if not needed Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/cd920b72_72197c73?usp=email : PS9, Line 142: (ClientInfoResponseMessage) messageFuture.get(DEFAULT_NC_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); > As discussed, this timeout is unlimited. […] Done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/7c0deaf4_ef586c6e?usp=email : PS9, Line 98: public IClientRequest getAsyncOrDeferredRequest(String requestId) { > Maybe use Optional? Done File hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/result/ResultSetReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/9f495bc3_cbfd2201?usp=email : PS9, Line 196: throw new RuntimeException(e); > replace this Done File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/26021da0_3fcbb302?usp=email : PS9, Line 113: ((ResultPartitionWriter) resultPartitionWriter).incrementResultCount(); > Just make sure this is a safe downcast Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I25c0651531a8a48271c901a7368d8668874a9d18 Gerrit-Change-Number: 20378 Gerrit-PatchSet: 11 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 17:11:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ian Maxon <[email protected]>
