>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ian Maxon, Peeyush Gupta.
Murtadha Hubail has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email ) Change subject: [ASTERIXDB-3649][*DB] Improve async request API ...................................................................... Patch Set 11: (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DiscardResultRequestMessage.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/2153f357_000f09f3?usp=email : PS11, Line 54: DiscardResultResponseMessage response = new DiscardResultResponseMessage(this.ncReqId); do we need this response? File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/6ac2a066_25794832?usp=email : PS11, Line 74: this.selectedMetrics = selectedMetrics == null ? Set.of(Metrics.values()) : selectedMetrics; make static -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I25c0651531a8a48271c901a7368d8668874a9d18 Gerrit-Change-Number: 20378 Gerrit-PatchSet: 11 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 19:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
