>From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb.
Ali Alsuliman has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866?usp=email ) Change subject: [NO ISSUE][EXT]: ensure no dependent collections on catalog drop ...................................................................... Patch Set 3: (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/handlers/CatalogStatementHandler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/7f130ced_77325fea?usp=email : PS3, Line 121: beforeAddTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); : MetadataManager.INSTANCE.addCatalog(mdTxnCtx, getCatalog(statement)); : MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); Same here? ``` MetadataManager.INSTANCE.addCatalog(mdTxnCtx, getCatalog(statement)); beforeAddTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); ``` https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/6688e5d2_3346b622?usp=email : PS3, Line 151: beforeDropTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); : MetadataManager.INSTANCE.dropCatalog(mdTxnCtx, catalogName); : MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); I just noticed this. Don't you need the sequence to be: ``` MetadataManager.INSTANCE.dropCatalog(mdTxnCtx, catalogName); beforeDropTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); ``` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I52bafb87fbe5fb856a6220ee11b2bf985bc3b70c Gerrit-Change-Number: 20866 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 16:32:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
