>From Hussain Towaileb <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866?usp=email ) Change subject: [NO ISSUE][EXT]: ensure no dependent collections on catalog drop ...................................................................... Patch Set 3: (5 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/handlers/CatalogStatementHandler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/831d940b_eb258841?usp=email : PS2, Line 169: List<Dataset> collections = getCollectionsCreatedOnToCatalog(mdTxnCtx, catalogName); > We typically check dependencies inside the `MetadataNode`. You can see > examples there (e.g. […] Done, no reason, just wasn't aware of it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/197ba02d_e2327a56?usp=email : PS2, Line 169: getCollectionsCreatedOnToCatalog > getCollectionsCreatedOnCatalog* (will fix in a follow up) Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/handlers/CatalogStatementHandler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/7422889e_11f3bd97?usp=email : PS3, Line 121: beforeAddTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); : MetadataManager.INSTANCE.addCatalog(mdTxnCtx, getCatalog(statement)); : MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); > Same here? […] Good catch, fixed. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/f10ebed3_503ee3f3?usp=email : PS3, Line 151: beforeDropTxnCommit(metadataProvider, creator, EntityDetails.newCatalog(catalogName)); : MetadataManager.INSTANCE.dropCatalog(mdTxnCtx, catalogName); : MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); > I just noticed this. Don't you need the sequence to be: […] Good catch, fixed. File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_iceberg.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866/comment/cdfbba9f_f1d8e03a?usp=email : PS2, Line 65: <expected-error>ASX1243: Cannot drop catalog 'myGlueCatalog' because it has the following dependent collections: '[test, test2]'</expected-error> > these single quotes `'[test, test2]'` don't seem right- I think I would just > remove them Done, this is now replaced by another error message that we already have in place. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20866?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I52bafb87fbe5fb856a6220ee11b2bf985bc3b70c Gerrit-Change-Number: 20866 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 17:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: Michael Blow <[email protected]> Comment-In-Reply-To: Hussain Towaileb <[email protected]>
