abdullah alamoudi has posted comments on this change. Change subject: Unify structure of Cluster Controller and Node Controller ......................................................................
Patch Set 10: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplication.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplication.java: PS10, Line 28: IHyracksClientConnection > Why Hcc is part of an CC Application? It looks to be a client-side thing. Done https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java: PS10, Line 72: null > Why context is an Object? I think Object is the right level. Let's discuss and address it in a subsequent change? This is supposed to be something Hyracks is unaware of completely. Not sure what kind of abstraction we would put PS10, Line 75: Override > Why A ICCApplication needs hcc? Done https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/BaseNCApplication.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/BaseNCApplication.java: PS10, Line 71: getApplicationContext > Why context is an Object? I think Object is the right level. Let's discuss and address it in a subsequent change? This is supposed to be something Hyracks is unaware of completely. Not sure what kind of abstraction we would put -- To view, visit https://asterix-gerrit.ics.uci.edu/1514 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife3a002371a07ee9cdd32e1ffd50cc775bf1d453 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
