Yingyi Bu has posted comments on this change. Change subject: Unify structure of Cluster Controller and Node Controller ......................................................................
Patch Set 11: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java: PS10, Line 72: null > I think Object is the right level. Let's discuss and address it in a subseq Here is my general rule: If an getXXX returns an Object in interface IYYY, it basically means the method does not need to exist in the interface IYYY --- because in any call site of getXXX, the caller can only bind to one particular concrete sub-type of IYYY and do the casting, in order to use the Object. -- To view, visit https://asterix-gerrit.ics.uci.edu/1514 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife3a002371a07ee9cdd32e1ffd50cc775bf1d453 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
