>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email ) Change subject: [ASTERIXDB-3542] Added Coordinate Reference System support at Metadata and ST Transform function ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STTransformDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/17fe5f85_2aaade04?usp=email : PS4, Line 203: Geometry transformed = (Geometry) geometry.copy(); who do we have to copy the geometry here? can't we just directly transform `geometry`? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/60824433_bf2181b4?usp=email : PS4, Line 243: geometry.apply(new CoordinateSequenceFilter() { won't making this create a new object at every invocation? do we need that, or can this be factored out? File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/crs/CRSCreateStatement.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/a4fd7a8a_9280ae2c?usp=email : PS4, Line 32: public CRSCreateStatement(int srid, String crsName, String crsWkt, boolean ifNotExists) { i think CRSes should exist within a database/dataverse. i don't see where in the APE we said they should be global. you could make the argument that since (some of) our SRIDs are supposed to correspond to what's in the EPSG dataset, that the ones that are defined there could be global, but then you'd still have the custom ones. i think it will be easier at least at first to just make them exist within a database. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b214926412c16ac Gerrit-Change-Number: 20968 Gerrit-PatchSet: 4 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 23:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
