>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email ) Change subject: [ASTERIXDB-3542] Added Coordinate Reference System support at Metadata and ST Transform function ...................................................................... Patch Set 4: (2 comments) File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STTransformDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/a71ca00b_cf1db4a4?usp=email : PS4, Line 243: geometry.apply(new CoordinateSequenceFilter() { > Yes the anonymous class would allocate objects per call, but it's a tiny > object and is thread safe. […] it's single threaded at the point of evaluate(...), which is the only caller of this. the CoordinateSequenceFilter itself is supposed to be a visitor according to the docs, so i don't think instantiating the visitor once and visiting each geometry with it is an inappropriate use File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/crs/CRSCreateStatement.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/4bb80bf9_506aa138?usp=email : PS4, Line 32: public CRSCreateStatement(int srid, String crsName, String crsWkt, boolean ifNotExists) { > I believe Starting global is the simpler long-term design, the previous APE > is outdated and doesn't […] 1. SRIDs are not global in PostGIS. insert a new CRS into spatial_ref_sys . then create a new database and initialize the extension. the CRS you just defined won't be in spatial_ref_sys. 2. a query working differently depending on what database you use it in, is not an example of nondeterminism. it is an expected effect of scoping. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b214926412c16ac Gerrit-Change-Number: 20968 Gerrit-PatchSet: 4 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2026 21:36:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Suryaa Charan Shivakumar <[email protected]>
