>From Ali Alsuliman <[email protected]>: Attention is currently required from: Michael Blow.
Ali Alsuliman has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223?usp=email ) Change subject: [NO ISSUE][RT] Enable VSizeFrame allocation extension ...................................................................... Patch Set 9: (5 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/018cf454_a6186081?usp=email : PS9, Line 117: IntSerDeUtils.putInt(input.array(), FrameHelper.getTupleCountOffset(input.limit()), tc); You want to check this? (i.e. message is big and after removing the message the newSize is < original message size) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/resources/memory/IFrameProfiler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/ddc951f1_32f39dce?usp=email : PS9, Line 50: void reportReallocate(int oldSize, int newSize, JobId jobId, JobKind jobKind); I can check myself in this patch, but are `reportReclamation()` and `reportReallocate()` mutually exclusive (i.e. in case we are resizing to the minimum size). File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/resources/memory/FrameManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/a026b5ed_0a7bebce?usp=email : PS9, Line 88: ByteBuffer buffer = allocateFrame(newSizeInBytes); double reporting? File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFrameMemoryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/fd0a99c8_ba07fa52?usp=email : PS9, Line 102: int frameSize = frame.limit(); Want to check this one? File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/cc3be536_2d022c00?usp=email : PS9, Line 160: return (long) frameAccessor.getBuffer().limit() + ptrSize * frameAccessor.getTupleCount() * Integer.BYTES; Want to check this one? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I492d341e84675cca57cef937fcbf4851379981cf Gerrit-Change-Number: 21223 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 21:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
