>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon.
Michael Blow has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223?usp=email ) Change subject: [NO ISSUE][RT] Enable VSizeFrame allocation extension ...................................................................... Patch Set 10: (6 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/b0b8f5ee_44216d99?usp=email : PS9, Line 117: IntSerDeUtils.putInt(input.array(), FrameHelper.getTupleCountOffset(input.limit()), tc); > You want to check this? (i.e. […] I've added supporting comments. File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobFlag.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/d566dd21_aba7cfd0?usp=email : PS9, Line 25: STICKY_FRAMES > revert, unused Done File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/resources/memory/IFrameProfiler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/c5f2abaf_565e5540?usp=email : PS9, Line 50: void reportReallocate(int oldSize, int newSize, JobId jobId, JobKind jobKind); > I can check myself in this patch, but are `reportReclamation()` and > `reportReallocate()` mutually ex […] I have clarified in reportReclamation() javadoc, that a reallocation will be reported as part of any reclamation. File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/resources/memory/FrameManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/dd2ef6d2_0854d71e?usp=email : PS9, Line 88: ByteBuffer buffer = allocateFrame(newSizeInBytes); > double reporting? Done File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFrameMemoryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/0c476f83_8999b232?usp=email : PS9, Line 102: int frameSize = frame.limit(); > Want to check this one? I've added supporting comments. File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223/comment/2e20556d_2c1f6c07?usp=email : PS9, Line 160: return (long) frameAccessor.getBuffer().limit() + ptrSize * frameAccessor.getTupleCount() * Integer.BYTES; > Want to check this one? I've added supporting comments. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21223?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I492d341e84675cca57cef937fcbf4851379981cf Gerrit-Change-Number: 21223 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 03:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: Michael Blow <[email protected]>
