>From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb, Ian Maxon, Michael Blow, Murtadha Hubail.
Ali Alsuliman has posted comments on this change by Ali Alsuliman. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275?usp=email ) Change subject: [ASTERIXDB-3649][HYR] Measure result expiry since job complete ...................................................................... Patch Set 2: (1 comment) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275/comment/be253ac0_02171271?usp=email : PS2, Line 88: volatile > why volatile? isn't the only caller of this within a synchronized? or is it > like the stats where onl […] By "within a synchronized", do you mean `synchronized void notifyJobFinish()` of `CCServiceContext`? That is the writing thread. The reading thread is the `ResultStateSweeper` which synchronizes on `ResultDirectoryService`. I believe those two are different monitors, so they are not going to see the happens-before relationship on `jobEndTime` and volatile is needed for the sweeper to see the effect of the write. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I33eecf8f907e009da05482255e4f214a39e601c2 Gerrit-Change-Number: 21275 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 22 May 2026 02:41:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
