>From Ali Alsuliman <[email protected]>:

Attention is currently required from: Hussain Towaileb, Ian Maxon, Michael Blow.

Ali Alsuliman has posted comments on this change by Ali Alsuliman. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275?usp=email )

Change subject: [ASTERIXDB-3649][HYR] Measure result expiry since job complete
......................................................................


Patch Set 2:

(3 comments)

File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/IResultStateRecord.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275/comment/38edd2ca_d9e73fb9?usp=email
 :
PS2, Line 36: getCompleteTimestamp
> Include unit?
Acknowledged


File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/result/ResultJobRecord.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275/comment/13861cca_d11fb501?usp=email
 :
PS2, Line 88: volatile
> By "within a synchronized", do you mean `synchronized void notifyJobFinish()` 
> of `CCServiceContext`? […]
Done


File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/result/AbstractResultManager.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275/comment/0eab7c0f_dc571a1a?usp=email
 :
PS2, Line 54: 0
> This should be a constant in state or isComplete in state
Acknowledged



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21275?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I33eecf8f907e009da05482255e4f214a39e601c2
Gerrit-Change-Number: 21275
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Fri, 22 May 2026 13:03:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail <[email protected]>
Comment-In-Reply-To: Ian Maxon <[email protected]>
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to