Yingyi Bu has posted comments on this change. Change subject: Ensure Metadata locks are acquired for SqlPP queries ......................................................................
Patch Set 12: (3 comments) Mostly LGTM. Detailed comments are inlined. https://asterix-gerrit.ics.uci.edu/#/c/1642/12/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/LockList.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/LockList.java: PS12, Line 28: ArrayList Using LinkedHashSet seems more efficient? Set<Pair<Mode, IMetadataLock>> locks = new LinkedHashSet(); (Assume that Mode, IMetadataLock has the right implementation for equals() and hashCode()) It provides fast membership check in add(Mode, IMetadataLock), so that the size of locks can be bounded by the number used datasets in a query. In addition, it provides guaranteed insertion-order traversal. https://asterix-gerrit.ics.uci.edu/#/c/1642/12/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: PS12, Line 60: String dv name, ds name looks redundant since we already have Dataset. PS12, Line 96: dataverseName dv name, ds name looks redundant since we already have Dataset. -- To view, visit https://asterix-gerrit.ics.uci.edu/1642 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
