abdullah alamoudi has posted comments on this change. Change subject: Ensure Metadata locks are acquired for SqlPP queries ......................................................................
Patch Set 12: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1642/12/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/LockList.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/LockList.java: PS12, Line 28: ArrayList > Using LinkedHashSet seems more efficient? Yingyi, I looked into this and it is not straight forward. For once, an IMetadataLock doesn't know what it locks. the mapping from entities to locks is still in the MetadataLockManager. Since this is an optimization, I suggest we do it later? https://asterix-gerrit.ics.uci.edu/#/c/1642/12/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: PS12, Line 60: String > dv name, ds name looks redundant since we already have Dataset. Done PS12, Line 96: dataverseName > dv name, ds name looks redundant since we already have Dataset. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1642 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
