Xikui Wang has posted comments on this change. Change subject: Added long-term test to verify pre-distributed jobs fix ......................................................................
Patch Set 8: (5 comments) I added several comments to the parts that I am not quite follow. :) https://asterix-gerrit.ics.uci.edu/#/c/1657/8/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java: Line 66: tempMdProvider.getLocks().reset(); Do we need to reset locks in every for loop? It seems one is enough? Line 72: tempMdProvider.getLocks().reset(); Same as 1st one. Line 79: tempMdProvider.getLocks().reset(); Same as 1st one. https://asterix-gerrit.ics.uci.edu/#/c/1657/8/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java: Line 121: tempMdProvider.setConfig(metadataProvider.getConfig()); Can you put a small note on this temporary MetadataProvider? I guess I'm lost in the context here... :) Line 128: tempMdProvider.getLocks().reset(); If everything goes smoothly, I guess the lock list should be empty? Is the explicit reset necessary here? -- To view, visit https://asterix-gerrit.ics.uci.edu/1657 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e799e203f6ca6082f9c90f04e606c436eb00ee Gerrit-PatchSet: 8 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
