Steven Jacobs has posted comments on this change. Change subject: Added long-term test to verify pre-distributed jobs fix ......................................................................
Patch Set 8: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1657/8/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java: Line 66: tempMdProvider.getLocks().reset(); > Do we need to reset locks in every for loop? It seems one is enough? In order to re-use the same metadata provider, we have to reset the locks each time before trying to use it again (at least thats the advice from Abdullah). Line 72: tempMdProvider.getLocks().reset(); > Same as 1st one. same :) Line 79: tempMdProvider.getLocks().reset(); > Same as 1st one. Same :) https://asterix-gerrit.ics.uci.edu/#/c/1657/8/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java: Line 121: tempMdProvider.setConfig(metadataProvider.getConfig()); > Can you put a small note on this temporary MetadataProvider? I guess I'm lo Done. Basically, when one handle calls another, the locks get messed up if we use the same provider for the nested call, so we instead make a copy of it. Line 128: tempMdProvider.getLocks().reset(); > If everything goes smoothly, I guess the lock list should be empty? Is the Again this was the recommendation from Abdullah. -- To view, visit https://asterix-gerrit.ics.uci.edu/1657 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e799e203f6ca6082f9c90f04e606c436eb00ee Gerrit-PatchSet: 8 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
