Xikui Wang has posted comments on this change. Change subject: ASTERIXDB-1883: FeedRuntimeInputHandler issues ......................................................................
Patch Set 1: (1 comment) Sorry for the issue that was created in that patch. I only have a minor question regarding to a small part, besides that everything looks good. I did some investigation about the verification error. It's in org/apache/asterix/external/feed/test/InputHandlerTest.java:742. After all frames are consumed in the writer, it's possible that the spiller runs ahead of the Assertion at line 742 which causes the Assertion error. Comment this line should be fine... Hope this will help. Thanks for fixing this!!! https://asterix-gerrit.ics.uci.edu/#/c/1677/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java: Line 401: if (consume(frame) != null) { A minor question. Since we clear all local frames here, I guess there will be more SPILLED in the inbox than the actual frames in the spiller? Do we want to dequeue those frames in inbox here as well? (This may cause problem as well.. Not sure...) -- To view, visit https://asterix-gerrit.ics.uci.edu/1677 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e091f65eb5f3a76277803b3197d490d3ef2fc04 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
