abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1883: FeedRuntimeInputHandler issues ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1677/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java: PS1, Line 122: try { : framePool.release(inbox); : } catch (Throwable th) { : LOGGER.log(Level.WARNING, "exception releasing buffers", th); : } inbox should be empty at this point. no need to call release. also, releasing the poison pill or the spill frame would be bad -- To view, visit https://asterix-gerrit.ics.uci.edu/1677 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e091f65eb5f3a76277803b3197d490d3ef2fc04 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
