Ildar Absalyamov has posted comments on this change. Change subject: Enable job compilation for variables that will be created at runtime ......................................................................
Patch Set 5: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1722/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java: PS5, Line 136: .*; I think our standard formatter settings disable wildcard imports https://asterix-gerrit.ics.uci.edu/#/c/1722/5/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/GetRuntimeContextVariableDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/GetRuntimeContextVariableDescriptor.java: PS5, Line 63: length - 1 Why the result length is shortened? https://asterix-gerrit.ics.uci.edu/#/c/1722/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/RuntimeContextVariableByteStore.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/RuntimeContextVariableByteStore.java: PS5, Line 45: if (key.length == length) { : boolean matched = true; : for (int j = 0; j < length; j++) { : if (key[j] != name[j + start]) { : matched = false; : break; : } : } Can be substituted by Arrays.equals(...) -- To view, visit https://asterix-gerrit.ics.uci.edu/1722 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
