Steven Jacobs has posted comments on this change. Change subject: Enable job compilation for variables that will be created at runtime ......................................................................
Patch Set 5: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/1722/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java: PS5, Line 136: .*; > I think our standard formatter settings disable wildcard imports Okay, I'll change this. Done. https://asterix-gerrit.ics.uci.edu/#/c/1722/5/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/GetRuntimeContextVariableDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/GetRuntimeContextVariableDescriptor.java: Line 53: return new AbstractUnaryStringStringEval(ctx, args[0], GetRuntimeContextVariableDescriptor.this.getIdentifier()) { > MAJOR SonarQube violation: Done PS5, Line 63: length - 1 > Why the result length is shortened? Done https://asterix-gerrit.ics.uci.edu/#/c/1722/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java: Line 174: public StartJobFunction(DeploymentId deploymentId, byte[] acggfBytes, EnumSet<JobFlag> jobFlags, JobId jobId, > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1722/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/RuntimeContextVariableByteStore.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/RuntimeContextVariableByteStore.java: Line 44: for (byte[] key : vars.keySet()) { > MAJOR SonarQube violation: Done PS5, Line 45: if (key.length == length) { : boolean matched = true; : for (int j = 0; j < length; j++) { : if (key[j] != name[j + start]) { : matched = false; : break; : } : } > Can be substituted by Arrays.equals(...) I don't think so. Since we only want to look at a subset of the bytes in "name", we would have to use Arrays.copyOfRange on "name" which would create an object. Line 58: return null; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1722/5/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestTaskContext.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestTaskContext.java: Line 161: return null; > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1722 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
