Yingyi Bu has posted comments on this change. Change subject: Implemented LSM disk components alignment ......................................................................
Patch Set 16: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1725/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: PS16, Line 95: IllegalStateException > Got it. BTW, I saw "All message templates should be tested.", but where sho Currently not every exception path are covered by tests: Here're a few places that test error code: 1. org.apache.asterix.om.typecomputer.ExceptionTest, which enumerates all possible input types for all type computer implementations and verifies the error code; 2. org.apache.asterix.runtime.ExceptionIT, which enumerate all possible runtime input types for all function evaluator implementations and verifies the error code; MockIto allows you to cover cold code paths in a relative easy way. -- To view, visit https://asterix-gerrit.ics.uci.edu/1725 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bf34e255def72adc73b9f87cfa628a172ea694 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
