Luo Chen has posted comments on this change. Change subject: Implemented LSM disk components alignment ......................................................................
Patch Set 18: > >> Now we need to create a new disk component > >> for each disk component of the primary. > > To get this work, when you are at a tuple in a disk component, you > need to search it in all previous disk components to see whether > the secondary key value changes? If secondary key value changes, > you need to delete the old entry in the 2ndary index (by adding an > anti-matter entry)? > > > An alternative might be to flush and compact primary index to one > disk component before bulk loading a 2ndary index. I think the first comment is to address the issue caused by upsert? I haven't considered too much about implementing newly created secondary index, and this would be a separate patch after the correlated merge policy. By the way, it might not be desirable to merge all disk components into one, because for some applications like Cloudberry, it's desirable to have many small disk components and use filters to filter out most of them during the query. I would need to check with the user (i.e., Cloudberry) to see whether this is a acceptable side-effect. -- To view, visit https://asterix-gerrit.ics.uci.edu/1725 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bf34e255def72adc73b9f87cfa628a172ea694 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
