Yingyi Bu has posted comments on this change. Change subject: Added built-in functions: ifmissing(), ifnull(), ifmissingornull() ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md File asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md: PS3, Line 22: if_null Add an example to each function as other functions? E.g., https://ci.apache.org/projects/asterixdb/sqlpp/builtins.html#StringFunctions PS3, Line 27: WS https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java: PS3, Line 55: case ANY can be merged to "default:" ? PS3, Line 59: Is the ANY/UNION case covered by the added tests? I think the SWITCH-CASE expressions in tests should cover one of them. For ANY, you can create a datatset with open fields inserted. For UNION, you can create a dataset with optional fields: https://ci.apache.org/projects/asterixdb/sqlpp/manual.html#Types PS3, Line 114: IllegalArgumentException Follow the error message guideline and use error code? https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling PS3, Line 131: WS -- To view, visit https://asterix-gerrit.ics.uci.edu/1745 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id114f6654b9814c5aeca07fffeea04daeb8dca19 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
