Dmitry Lychagin has posted comments on this change. Change subject: Added built-in functions: ifmissing(), ifnull(), ifmissingornull() ......................................................................
Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md File asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md: PS3, Line 22: if_null > Add an example to each function as other functions? yes, I've added examples in the new patch https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java: PS3, Line 55: > case ANY can be merged to "default:" ? yes. merged in the new version PS3, Line 59: > Is the ANY/UNION case covered by the added tests? 'union' is covered by switch-case. 'any' has been merged into default, so I think we're ok now. PS3, Line 114: esultTypeComputer IF_MIS > Follow the error message guideline and use error code? yes. done -- To view, visit https://asterix-gerrit.ics.uci.edu/1745 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id114f6654b9814c5aeca07fffeea04daeb8dca19 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
