Yingyi Bu has posted comments on this change. Change subject: Add a dataset rebalance REST API. ......................................................................
Patch Set 16: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java: PS15, Line 65: APPLICATI > Why HTML and not JSON? Done https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java: PS15, Line 3: * or more contributor license agreements. See the NOTICE file > Double comments. Done https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml File asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml: PS15, Line 4: ! dist > s/ ~ * Licensed/ ! Licensed/ Done https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java: PS15, Line 35: admin/reb > s#/rebalance#/admin/rebalance# or something similar? Done https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryInvertedIndexOperationsHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryInvertedIndexOperationsHelper.java: PS15, Line 214: IOperatorDescriptor keyProviderOp = DatasetUtil.createDummyKeyProviderOp(spec, dataset, metadataProvider); : > single line? Done PS15, Line 218: jobId); : > single line? one more character for staying in a single line. https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryRTreeOperationsHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryRTreeOperationsHelper.java: PS15, Line 205: IOperatorDescriptor keyProviderOp = DatasetUtil.createDummyKeyProviderOp(spec, dataset, metadataProvider); : JobId jobId = IndexUtil.bi > single line? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1768 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda35252031fc4940972f0f19bbf796cadfa53d6 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
