Michael Blow has posted comments on this change. Change subject: Add a dataset rebalance REST API. ......................................................................
Patch Set 16: Code-Review+1 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1768/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/DatasetIdFactory.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/DatasetIdFactory.java: PS16, Line 41: id.compareAndSet(Integer.MAX_VALUE, startId); is negative dataset id illegal? if not, this is cutting the number of datasets by half. either way, I think we should throw exception instead of just quietly wrapping around to 0, and we should file an issue to track how to reclaim dropped dataset ids. -- To view, visit https://asterix-gerrit.ics.uci.edu/1768 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda35252031fc4940972f0f19bbf796cadfa53d6 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
