Yingyi Bu has posted comments on this change. Change subject: Change DataflowHelperFactory not to require Task Context ......................................................................
Patch Set 4: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1758/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java: PS4, Line 43: ICCMessageBroker Add public methods to the interface? PS4, Line 90: requestFromNcs requestFromNcs -> sendSyncRequestToNCs This method is not called by anyone. Do you have a corresponding CB change? PS4, Line 113: HyracksDataException The error code is in *DB, hence, it should better be an AsterixException. I don't think HyracksDataException is able to find the error message for that error code. PS4, Line 125: IllegalStateException("Unexpected response stat error code PS4, Line 132: respond What's this method used for? This method is not called by anyone. Do you have a corresponding CB change? https://asterix-gerrit.ics.uci.edu/#/c/1758/4/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS4, Line 54: ss one more s? -- To view, visit https://asterix-gerrit.ics.uci.edu/1758 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dcd95dbefca131c4bbdb43306f00f6f8ea60800 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
