Till Westmann has posted comments on this change.

Change subject: Change DataflowHelperFactory not to require Task Context
......................................................................


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1758/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java:

PS4, Line 113: HyracksDataException
> The error code is in *DB, hence, it should better be an AsterixException.  
I think that a RuntimeDataException (or a subclass) might the the right choice 
here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1758
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcd95dbefca131c4bbdb43306f00f6f8ea60800
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to