Michael Blow has posted comments on this change. Change subject: Fix QueryCancellationServlet use of e.getMessage() ......................................................................
Patch Set 1: > When should/shouldn't we use e.getMessages() for logging? I think > we have logged e.getMessages() in a number of places. It is OK to use getMessage() when the exception type is well-known to have useful messages, e.g. AsterixException & HyracksException, but JVM exceptions for example rarely have useful messages out of context of the class, and often are null. e.g. IllegalArgumentException, ArrayIndexOutOfBoundsException, NullPointerException -- To view, visit https://asterix-gerrit.ics.uci.edu/1809 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5e2172728d3bc4d0cc4a9990518adcd91ae76b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
