Michael Blow has submitted this change and it was merged. Change subject: Fix QueryCancellationServlet use of e.getMessage() ......................................................................
Fix QueryCancellationServlet use of e.getMessage() Correct log message to not utilize getMessage() on arbitrary exceptions Change-Id: I1f5e2172728d3bc4d0cc4a9990518adcd91ae76b Reviewed-on: https://asterix-gerrit.ics.uci.edu/1809 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> BAD: Jenkins <[email protected]> Reviewed-by: Yingyi Bu <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryCancellationServlet.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Yingyi Bu: Looks good to me, approved Jenkins: Verified; No violations found; No violations found; Verified diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryCancellationServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryCancellationServlet.java index 4405d29..bfec146 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryCancellationServlet.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryCancellationServlet.java @@ -72,9 +72,7 @@ // response: OK response.setStatus(HttpResponseStatus.OK); } catch (Exception e) { - if (LOGGER.isLoggable(Level.WARNING)) { - LOGGER.log(Level.WARNING, e.getMessage(), e); - } + LOGGER.log(Level.WARNING, "unexpected exception thrown from cancel", e); // response: INTERNAL SERVER ERROR response.setStatus(HttpResponseStatus.INTERNAL_SERVER_ERROR); } -- To view, visit https://asterix-gerrit.ics.uci.edu/1809 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5e2172728d3bc4d0cc4a9990518adcd91ae76b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]>
