Yingyi Bu has posted comments on this change. Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle ......................................................................
Patch Set 11: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1930/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java: PS12, Line 59: synchronized (this) { Why do you need to synchronize on "this"? Other dsInfo.undeclareActiveIOOperation() calls do not synchronize on "this", e.g., the one in afterOperation(). -- To view, visit https://asterix-gerrit.ics.uci.edu/1930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
