Yingyi Bu has posted comments on this change. Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle ......................................................................
Patch Set 12: (1 comment) >>Had a discussion about this with Mike Carey. >>we will log warning for double deletion (not fail) >>but we should still never do it... I still couldn't clearly see the upside of doing so by ourselves. It seems like that you are overriding sth. that the OS has already provided. - For better user experience? The same thing is logged and no exception is thrown. - For debugging purpose? But from the logged warnings, there's no difference. - For better design? It complicates the synchronization etc. Maybe we should discuss offline. https://asterix-gerrit.ics.uci.edu/#/c/1930/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java: PS12, Line 59: synchronized (this) { > other is called from a synchronized block... Why do need two synchronizations to protect this one counter? In other words, what will be a problem if you don't synchronize on "this"? -- To view, visit https://asterix-gerrit.ics.uci.edu/1930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
