Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2083/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS1, Line 684: processor > Should this be after the first "try {" ? Unfortunately, processor.start() sets the correct index operation before entering the component, so it should be before enter. Didn't want to introduce a bigger change to change that behavior at this point in time. -- To view, visit https://asterix-gerrit.ics.uci.edu/2083 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
