Till Westmann has posted comments on this change. Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2083/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS1, Line 684: processor > Maybe we do But if processFrame throws, then processor.finish() won't be called. Is that intended? PS1, Line 684: processor > Unfortunately, processor.start() sets the correct index operation before en I see. Yet another example why looking at the correct nesting should be a part of every code review :) -- To view, visit https://asterix-gerrit.ics.uci.edu/2083 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
