Till Westmann has posted comments on this change. Change subject: [NO ISSUE][TX] Introduce Atomic Transactions ......................................................................
Patch Set 4: (9 comments) First round - mostly trivial. https://asterix-gerrit.ics.uci.edu/#/c/2156/4//COMMIT_MSG Commit Message: PS4, Line 13: - Redesign and simplify ITransactionContext API Remove one of these? PS4, Line 20: transaction transactions PS4, Line 20: transaction transactions PS4, Line 21: transaction transactions https://asterix-gerrit.ics.uci.edu/#/c/2156/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java: PS4, Line 31: COMMITTD COMMITTED https://asterix-gerrit.ics.uci.edu/#/c/2156/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java: PS4, Line 64: IllegalStateException This seems a little out of place ... PS4, Line 70: IllegalStateException ... while this seems to be a genuine IllegalStateException. https://asterix-gerrit.ics.uci.edu/#/c/2156/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java: PS4, Line 70: IllegalStateException This seems a little out of place. https://asterix-gerrit.ics.uci.edu/#/c/2156/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContextFactory.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContextFactory.java: PS4, Line 40: IllegalStateException IllegalArgumentException? -- To view, visit https://asterix-gerrit.ics.uci.edu/2156 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13db1c15f8afbdaae608ff0a7468fe62bf1daccd Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
