Michael Blow has posted comments on this change. Change subject: [NO ISSUE][TX] Introduce Atomic Transactions ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2156/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContextFactory.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContextFactory.java: PS4, Line 40: IllegalStateException > IllegalArgumentException? -1 - I think for missing enums cases in a switch- I like IllegalStateException... -- To view, visit https://asterix-gerrit.ics.uci.edu/2156 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13db1c15f8afbdaae608ff0a7468fe62bf1daccd Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes