Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter ......................................................................
Patch Set 2: (3 comments) Very cool, I have some questions if you wouldn't mind answering them. https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: PS2, Line 45: : private static final int DEFAULT_BLOOM_FILTER_VERSION = 0; : : private static final int BLOCKED_BLOOM_FILTER_VERSION = 1; Interesting, why's this different than the existing storage version? And how would we know there would be a 0 there before this? PS2, Line 142: : boolean unpinWhenExit = false; Why this and pagesPinned? Why're they different? PS2, Line 247: throw HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER); Why is this the case, that it can't be evicted? Won't this possibly interfere with dataset memory management? -- To view, visit https://asterix-gerrit.ics.uci.edu/2201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
