Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: PS2, Line 45: : private static final int DEFAULT_BLOOM_FILTER_VERSION = 0; : : private static final int BLOCKED_BLOOM_FILTER_VERSION = 1; > The old bloom filter didn't store this version information. And because of I see. And we are certainly initializing the unused space to 0? And what I mean by the existing storage version is the other version information that is not stored in the bloomfilter metadata, but rather in the local resource PS2, Line 247: throw HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER); > pinAllPages/unpinAllPages should be called by the query (e.g., a lot of pk How's it different though, than the normal lifecycle of an index? Deactivating any storage that is in use by a query would be bad. Why not just pin all the pages when it is active, and then unpin them when it is evicted? We do something similar during bulk load already. -- To view, visit https://asterix-gerrit.ics.uci.edu/2201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-HasComments: Yes
