Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2205][STO] Maintain includeMutableComponent correctly ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2243/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java: PS4, Line 303: pushIntoQueueFromCursorAndReplaceThisElement(mutableElement); > So was this the actual source of the bug, assigning the value returned here I think that the fix is in line 217, where includeMutableComponents is set independently of the value of switchedElements[i]. https://asterix-gerrit.ics.uci.edu/#/c/2243/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java: PS4, Line 53: private The change looks generally good to me. But changing this to private and moving to getters and setters seems inconsistent with the rest of the class - and it creates some noise in the other files. -- To view, visit https://asterix-gerrit.ics.uci.edu/2243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08a9372c608d6de960e1419899530aa55aa72e0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
