abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2205][STO] Maintain includeMutableComponent correctly ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2243/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java: PS4, Line 223: rangeCursors[i].close(); > Shouldn't this be reset() still since it's not based on the corrected API? Good catch. this happened because I built the fix on the corrected API then extracted it here. PS4, Line 303: pushIntoQueueFromCursorAndReplaceThisElement(mutableElement); > I think that the fix is in line 217, where includeMutableComponents is set Either of those by itself fixes the issue. Just wanted double protection https://asterix-gerrit.ics.uci.edu/#/c/2243/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java: PS4, Line 53: private > The change looks generally good to me. But changing this to private and mov It makes it easy when trying to navigate the code to be able to see who is just reading it vs. who is changing it. I can revert it too -- To view, visit https://asterix-gerrit.ics.uci.edu/2243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08a9372c608d6de960e1419899530aa55aa72e0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
