abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2083][COMP][RT][IDX][SITE] Budget-Constrained Inverted index search ......................................................................
Patch Set 29: (3 comments) Looks good overall. Minor comments. In addition to this, we should take care of the memory resources needed by the inverted index search. https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java: PS29, Line 144: CANNOT_CONTINUE_TEXT_SEARCH this seems to be used in many places and for different reasons. can we have either different error codes or at least include the reason as part of the error message? https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/api/IInvertedListCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/api/IInvertedListCursor.java: PS29, Line 27: IInvertedListCursor just a suggestion.. if we want this to be another cursor, let's extend EnforcedIndexCursor https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeFrameTupleAppender.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeFrameTupleAppender.java: PS29, Line 34: FixedSizeFrameTupleAppender There is another class with the same name (used for hash join I believe) FixedSizeFrameTupleAppender.. What is the difference between them? -- To view, visit https://asterix-gerrit.ics.uci.edu/2251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b2ef7c0b8c55ef66a5322be5d97ebbbf287bf5 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
